TheGame icon indicating copy to clipboard operation
TheGame copied to clipboard

[MyMeta] Guild profile images not queried & page format not aligned with player profiles

Open peth-yursick opened this issue 2 years ago • 1 comments

Guild profiles don't seem to be pulling in guild avatars. Not sure if this is true only of discord-based guilds or affecting some others as well but seems that for discord-based ones it doesn't work for sure.

Other than that, it would be good if guild profiles were formatted in the same way as player profiles. Right now, guild page boxes may be hardcoded like player ones were before.

Player profiles: image Guild profiles: image

peth-yursick avatar Jun 04 '22 09:06 peth-yursick

I think the issue here is that we are just hot-linking to guilds' logo images, so we have no recourse if e.g. the filename changes, the URL changes, etc. The Discord ones mostly do work, e.g. Opolis, Bloom.

We should be hosting these images ourselves, probably using Google Cloud CDN. @polimyl Any recommendations here?

alalonde avatar Jul 12 '22 15:07 alalonde

@alalonde we can use web3.storage for this right, since we already doing that for player profile images ? See https://github.com/MetaFam/TheGame/pull/1367

dan13ram avatar Oct 06 '22 20:10 dan13ram

Reopening since there is still the issue of Guild Logos, which is fixed in #1367

dan13ram avatar Oct 07 '22 07:10 dan13ram

Reopening since there is still the issue of Guild Logos, which is fixed in #1367

Didn't get this last bit "its still the issue, which is fixed"? 😂 I planned on manually uploading all guild logos to hasura today along with adding more links & info to each guild page and create a few of the missing guild pages (Atlantis World, Ark, Safary, rnDAO, YapDAO, Liminal Village, DAOhaus, Ethernaut DAO).. Would be awesome to not have to do each of these steps manually

peth-yursick avatar Oct 07 '22 09:10 peth-yursick