Ronnie Dutta

Oh I've just spotted earlier up the conversation @oliver-sanders was in the process of writing integration tests - any progress?

Fixed on master now. Kicking tests

I've sorted out the conflict and added a few tests in https://github.com/dwsutherland/cylc-flow/pull/19

Can build off https://github.com/cylc/cylc-doc/pull/686

I hadn't rebased, I had merged master into this branch for dwsutherland#19 (before you rebased this branch on top of master). There was a merge mistake when you pushed to...

Ah I see you've force pushed again - the merge mistake is here: https://github.com/cylc/cylc-flow/compare/598e0afe6c2e89cbcc6353f48e2363fe2dde34f2..8e7e3f17fc8832aa6ebb9a9dec800ec85d624762#diff-616dbf97f9b89762d7da3666f7ab3abf0cc3f2e6443b5367af9d25439a4321d5R334-R354 The fix is this ```diff diff --git a/cylc/flow/xtrigger_mgr.py b/cylc/flow/xtrigger_mgr.py index ea4b546da..762d8aa5b 100644 --- a/cylc/flow/xtrigger_mgr.py +++ b/cylc/flow/xtrigger_mgr.py...

``` # task_states table name cycle flow_nums time_created ... status ---------- ---------- ---------- --------------- ---------- a 1 [1] ... failed a 1 [1, 2] ... succeeded

So option 1

The full schema for `task_states` looks like ``` name cycle flow_nums time_created time_updated submit_num status flow_wait is_manual_submit ------ ------ ---------- -------------- -------------- ------------ -------- ----------- ---------------- TEXT TEXT TEXT TEXT...

``` # task_states table name cycle flow_nums time_created ... status ---------- ---------- ---------- --------------- ---------- a 1 [1] ... failed a 1 [1, 2] ... succeeded ``` How should we...