MetLee
MetLee
I found some hard-coding sentences: https://github.com/Fate-Grand-Automata/FGA/blob/61cf9636cdd591c090850e3a1cf31db07bf60038/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/BattleGroup.kt#L101-L102 https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/AdvancedGroup.kt#L81 https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/prefs/src/main/java/com/mathewsachin/fategrandautomata/prefs/core/GameAreaMode.kt#L4-L7 https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/AdvancedGroup.kt#L108
> Revert your last commit, the quotes are needed to keep the space at the end. Are the quotes correct?
And what's the "NP-matching card shuffle" mean?
> @MetLee Reminder I am not good at image processing. I guess that when the switch on, FGA will use the binary image (not the RGB image or the grayscale...
OK, I see. So it is just a feature which we don't know how well it works. This function only affects the new image and the old one is still...
I think that the user don't have to know how the feature works (but translator should figure it out), so I focus the translation on the binary image.