shellex icon indicating copy to clipboard operation
shellex copied to clipboard

encapsulate configuration file variables

Open pseyfert opened this issue 7 years ago • 0 comments

Reviewing #66 , I noticed $thefiles leaks into the shellex command line. It does not make it to the child process (cat $thefiles > /tmp/test yields and empty file) but echo $thefi⇥ completes the variable name and echo ${f}⇥ substitutes it. Declaring them local (local -a thefiles) is not an ad-hoc solution as they get solved. Atm unset thefiles at the end of shellexrc seems good to me, but not to interfere with possible user variables, I would prefer namespacing the shell variables in addition. Following typical completion functions, that would involve leading underscores in the variable name, and probably even shellex in the name.

I thought a bit if not-unsetting them and make them accessible to the user (for whatever they would want to do with them … debugging?) but since the behaviour is inconsistent (accessible to tabbing, inaccessible to processes), I assume it's not worth it.

pseyfert avatar Nov 18 '18 13:11 pseyfert