mobile icon indicating copy to clipboard operation
mobile copied to clipboard

WIP: fixed the space or rebound issue

Open kaustuvpokharel opened this issue 3 months ago • 4 comments

Case: In featureList whenever flickable is scrolled fast or scrolled out of bound; it rebounds and parks the feature below the "add feature" button awkwardly.

FIx: Fixed by making the end to be the absolute last feature, without any offsets of the rebound. Now even after rebound it lands/parks on the last feature without the "add feature" button overlapping it.

https://github.com/user-attachments/assets/43c92a77-6701-4700-a54b-f8c4a344d3dd

kaustuvpokharel avatar Oct 10 '25 20:10 kaustuvpokharel

Pull Request Test Coverage Report for Build 18618380989

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 19.631%

Files with Coverage Reduction New Missed Lines %
mm/app/attributes/attributecontroller.cpp 1 76.83%
build-mm-db/core/mm_core_autogen/EWIEGA46WW/moc_merginapi.cpp 3 44.31%
mm/core/merginuserauth.cpp 9 68.24%
mm/core/merginapi.cpp 14 74.98%
<!-- Total: 27
Totals Coverage Status
Change from base Build 18284755654: -0.02%
Covered Lines: 13932
Relevant Lines: 70969

💛 - Coveralls

github-actions[bot] avatar Oct 10 '25 21:10 github-actions[bot]

Rule of thumb, if you are fixing/working on UI show us how it looks/works :)

Withalion avatar Oct 10 '25 21:10 Withalion

I was building the ios still to take the screenshot, was about to attach. Anyway, thanks for the heads-up @Withalion

kaustuvpokharel avatar Oct 10 '25 21:10 kaustuvpokharel

Hi @kaustuvpokharel, so which of the two cacheBuffer/snapMode fixed the issue? :)

The cacheBuffer fixed it here, and I am explicitly using snapMode which is helping to fall to contentItem on view and not anywhere random i.e. empty spaces or such, so I have kept it for cleaner and safer approach.

kaustuvpokharel avatar Oct 28 '25 15:10 kaustuvpokharel

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 61601 dmg Expires: 18/03/2026 #6160
linux Build 📬 Mergin Maps 61711 x86_64 Expires: 18/03/2026 #6171
win64 Build 📬 Mergin Maps 53531 win64 Expires: 18/03/2026 #5353
Android Build 📭 Build not yet complete or failed.
iOS Build 📭 Build not yet complete or failed.

github-actions[bot] avatar Dec 18 '25 12:12 github-actions[bot]

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 61671 dmg Expires: 19/03/2026 #6167
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 53601 win64 Expires: 19/03/2026 #5360
Android Build 📬 Mergin Maps 747711 APK [armeabi-v7a] Expires: 19/03/2026 #7477
Android Build 📬 Mergin Maps 747751 APK [arm64-v8a] Expires: 19/03/2026 #7477
iOS Build 📬 Build number: 25.12.841811 #8418

github-actions[bot] avatar Dec 19 '25 12:12 github-actions[bot]