mobile icon indicating copy to clipboard operation
mobile copied to clipboard

Fix binding loop in MMListDelegate height calculation

Open VitorVieiraZ opened this issue 1 year ago • 3 comments

Moved height assignment to Component.onCompleted to break circular dependency between height and implicitHeight. MMListDelegate.qml:43:3: QML MMListDelegate: Binding loop detected for property "height" fixed.

Notes: Setting opacity instead of height to hide invisible items.

Screenshot 2024-10-17 at 10 23 59

VitorVieiraZ avatar Sep 10 '24 23:09 VitorVieiraZ

Pull Request Test Coverage Report for Build 11553196549

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 60.469%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/featuresmodel.cpp 1 68.52%
<!-- Total: 2
Totals Coverage Status
Change from base Build 11550175559: 0.02%
Covered Lines: 7884
Relevant Lines: 13038

💛 - Coveralls

github-actions[bot] avatar Sep 10 '24 23:09 github-actions[bot]

Did this solution help the issue Vitor? Can you please check if buttons on the map are behaving correctly? Especially the one with the streaming mode - when you navigate to edit line/polygon feature geometry

tomasMizera avatar Sep 25 '24 12:09 tomasMizera

Did this solution help the issue Vitor? Can you please check if buttons on the map are behaving correctly? Especially the one with the streaming mode - when you navigate to edit line/polygon feature geometry

Yes, waning is now fixed and working for these cases.

VitorVieiraZ avatar Sep 25 '24 14:09 VitorVieiraZ

Let's close this one and retry later

tomasMizera avatar Nov 06 '24 13:11 tomasMizera