slack-web icon indicating copy to clipboard operation
slack-web copied to clipboard

DUX-3346: Support custom deserializers in request verification

Open lf- opened this issue 8 months ago • 1 comments

This turns out to be necessary for the impressively messed up nonsense that Slack does with their interactive webhooks, which range from "json in a form parameter" (WHAT) to "entirely putting the thing in form parameters".

More code to support this may come in the future, but we need this foundation to be able to disentangle the bad code in mwb using this.

Sadly does a breaking change due to import Web.Slack.Experimental.RequestVerification (SlackVerificationFailed(..)) no longer importing constructors. The rest of this is not breaking changes.

Before submitting your PR, check that you've:

After submitting your PR:

  • [x] Update the Changelog.md file with a link to your PR
  • [x] Bumped the version number if there isn't an (unreleased) on the Changelog
  • [ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

lf- avatar Apr 15 '25 23:04 lf-