erela.js icon indicating copy to clipboard operation
erela.js copied to clipboard

Added spotify links to track object

Open exiify opened this issue 4 years ago • 2 comments

exiify avatar Apr 10 '21 17:04 exiify

It's hard to read what was changed with all the formatting but it seems like you changed the generic function that searches for songs, it isn't specific to Spotify and every other audio plugin would need to do the same, but there may be talk about changing how this works to another way more suited for it, such as a function the plugin needs to modify the data to keep certain properties

Solaris9 avatar Apr 10 '21 18:04 Solaris9

It's hard to read what was changed with all the formatting but it seems like you changed the generic function that searches for songs, it isn't specific to Spotify and every other audio plugin would need to do the same, but there may be talk about changing how this works to another way more suited for it, such as a function the plugin needs to modify the data to keep certain properties

Why don't we change spotifyUri to something like idk uri2 so every plugin can just return that too, and all I really changed was the getClosestTrack and I added the uri to the track as a string or null. The rest were really just formatting.

exiify avatar Apr 11 '21 11:04 exiify