Menghua Chen (MSFT)
Menghua Chen (MSFT)
@rajeshkamal5050 In the latest round of azd manual testing, this issue still exists. - Template: `todo-python-mongo-terraform`, `todo-nodejs-mongo-terraform`, `todo-java-postgresql-terraform`. - OS: Windows, Mac, DevContainer. - Branch: staging. - Azd version: azd...
@jongio Based on your suggestion, the code has been updated. Please review, thanks.
> @Menghua1 , you force-pushed your changes erasing my last commit. See my comment: [#3976 (comment)](https://github.com/Azure/azure-dev/pull/3976#issuecomment-2215405821). > > I have manually cancel the repo-man pipeline to avoid the issues with...
> **Main points:** > > * Keyvaults + keyvault access appear to be using the same resource module. Can these be merged > * Consistency issues with container app if...
> > What do you think of Wbreza's better middle ground solution? > > Let's get some app modules in azure-dev repo, but not in infra/core. They can be part...
@jongio [web-avm.bicep](https://github.com/Azure/azure-dev/blob/26963c93c6bb82afcf9f278954d5e4b9f5dd953b/templates/todo/common/infra/bicep/app/web-avm.bicep) is applicable to all front-ends using appservice (only for node), [api-avm.bivep](https://github.com/Azure/azure-dev/blob/26963c93c6bb82afcf9f278954d5e4b9f5dd953b/templates/todo/common/infra/bicep/app/api-avm.bicep) is applicable to all back-ends using appservice (for all language), and these two files can be applied...
@jongio We have wrapped the following five modules into `infra/app`. - [api-appservice-avm.bicep](https://github.com/Azure/azure-dev/blob/f1077a728b3211f249220c37c8d988f935d3f558/templates/todo/common/infra/bicep/app/api-appservice-avm.bicep) - [web-appservice-avm.bicep](https://github.com/Azure/azure-dev/blob/f1077a728b3211f249220c37c8d988f935d3f558/templates/todo/common/infra/bicep/app/web-appservice-avm.bicep) - [cosmos-mongo-db-avm.bicep](https://github.com/Azure/azure-dev/blob/f1077a728b3211f249220c37c8d988f935d3f558/templates/todo/common/infra/bicep/app/cosmos-mongo-db-avm.bicep) - [cosmos-sql-db-avm.bicep](https://github.com/Azure/azure-dev/blob/f1077a728b3211f249220c37c8d988f935d3f558/templates/todo/common/infra/bicep/app/cosmos-sql-db-avm.bicep) - [sqlserver-avm.bicep](https://github.com/Azure/azure-dev/blob/f1077a728b3211f249220c37c8d988f935d3f558/templates/todo/common/infra/bicep/app/sqlserver-avm.bicep) Besides, for modules that are simple and do not need...
> Does the App Service module that you're using include the right variable for AppInsights connection? The current version in azd does not, see my PR here: https://github.com/Azure/azure-dev/pull/4491/files#diff-69d520add196bb5fa4745a89b2450fa9066de6659da0977c1c3bfdf33da8bc14R95 @pamelafox Not...
@jongio At present, the migration to AVM has been completed. We have also done some simple testing of all templates locally and they have all been provisioned and deployed successfully....
> the test-templates pipelines is currently disabled/not-working. @ellismg is working for making it work again. You can only run the test-templates scripts manually for now. Once the test-templates pipelines work,...