Memori icon indicating copy to clipboard operation
Memori copied to clipboard

cleanup !

Open harshalmore31 opened this issue 1 month ago • 18 comments

This pull request introduces several improvements across the documentation and the MemoryAgent implementation, focusing on reliability, clarity, and performance. The documentation now provides clearer guidance on memory modes, SQL-based architecture advantages, and the interceptor pattern, while the codebase enhances error handling, duplicate detection, and logging in the memory agent.

Documentation Enhancements:

  • Memory Mode Selection Guidance:
    • Added a comprehensive decision matrix and quick selection guide to help users choose between Conscious, Auto, and Combined memory modes, including performance trade-offs and upgrade/downgrade scenarios.
  • SQL-Native Architecture Explanation:
    • Added a section comparing SQL-native memory storage to vector databases, highlighting cost, transparency, query speed, and portability benefits, along with best-use recommendations.
  • Interceptor Pattern and Internal Flow:
    • Detailed the interceptor pattern used by Memori for transparent LLM API call interception, including a three-phase process (context injection, memory recording, background analysis) and flow diagrams.
    • Expanded quick-start documentation with step-by-step explanations, flow diagrams, and instructions for inspecting and testing memory persistence in the SQL database.

MemoryAgent Reliability and Logging Improvements:

  • Robust Async API Calls:
    • Introduced an async retry mechanism with exponential backoff for handling connection and timeout errors in all OpenAI API calls, reducing transient failure rates. [1] [2] [3] [4]
    • Set explicit timeout and retry parameters for OpenAI client initialization to improve resilience.
  • Duplicate Detection Refinements:
    • Increased the similarity threshold for duplicate detection to 0.92 (from 0.8) to reduce false positives.
    • Skipped deduplication for conversational/query memories to avoid suppressing valid repeated queries.
    • Enhanced logging for duplicate detection, including detailed match information for easier debugging.
  • General Code Improvements:
    • Added missing asyncio import for async operations.

These changes collectively make Memori more reliable, transparent, and user-friendly, both in its documentation and core memory management logic.

harshalmore31 avatar Nov 11 '25 17:11 harshalmore31

Auto-Formatting Applied

Your code has been automatically formatted with:

  • Black (line-length: 88)
  • isort (import sorting)
  • Ruff (auto-fixes)

The changes have been committed to this PR. Please review and continue with your development!

github-actions[bot] avatar Nov 11 '25 17:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #268
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: c86021e035b2d086e4071b691483b3e617cb5028

github-actions[bot] avatar Nov 11 '25 17:11 github-actions[bot]

Code Formatting Check

Great job! Your code is already properly formatted according to our standards:

  • Black formatting
  • Import sorting
  • Ruff checks

No changes needed!

github-actions[bot] avatar Nov 11 '25 17:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #269
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: c245fffe731f567bbe7c725805f1fca7d307001d

github-actions[bot] avatar Nov 11 '25 17:11 github-actions[bot]

Auto-Formatting Applied

Your code has been automatically formatted with:

  • Black (line-length: 88)
  • isort (import sorting)
  • Ruff (auto-fixes)

The changes have been committed to this PR. Please review and continue with your development!

github-actions[bot] avatar Nov 13 '25 13:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #277
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: ad8d3b470bb70a014b473f31b512390670b614e9

github-actions[bot] avatar Nov 13 '25 13:11 github-actions[bot]

Code Formatting Check

Great job! Your code is already properly formatted according to our standards:

  • Black formatting
  • Import sorting
  • Ruff checks

No changes needed!

github-actions[bot] avatar Nov 13 '25 13:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #278
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: 29377f9e18f54c574a884ac0715bc8377940e739

github-actions[bot] avatar Nov 13 '25 13:11 github-actions[bot]

Code Formatting Check

Great job! Your code is already properly formatted according to our standards:

  • Black formatting
  • Import sorting
  • Ruff checks

No changes needed!

github-actions[bot] avatar Nov 13 '25 14:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #279
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: 4d24115ccde016c6d1e42ea62f1dbc1ec60609d4

github-actions[bot] avatar Nov 13 '25 14:11 github-actions[bot]

Auto-Formatting Applied

Your code has been automatically formatted with:

  • Black (line-length: 88)
  • isort (import sorting)
  • Ruff (auto-fixes)

The changes have been committed to this PR. Please review and continue with your development!

github-actions[bot] avatar Nov 15 '25 15:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #291
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: 27b11990ca30808056198f004c21aa06b21da776

github-actions[bot] avatar Nov 15 '25 15:11 github-actions[bot]

Auto-Formatting Applied

Your code has been automatically formatted with:

  • Black (line-length: 88)
  • isort (import sorting)
  • Ruff (auto-fixes)

The changes have been committed to this PR. Please review and continue with your development!

github-actions[bot] avatar Nov 15 '25 19:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #292
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: c37e713319844ff7a3dd6d2dbd5d4cdf10193e8d

github-actions[bot] avatar Nov 15 '25 19:11 github-actions[bot]

Auto-Formatting Applied

Your code has been automatically formatted with:

  • Black (line-length: 88)
  • isort (import sorting)
  • Ruff (auto-fixes)

The changes have been committed to this PR. Please review and continue with your development!

github-actions[bot] avatar Nov 15 '25 19:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #293
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: a1af275751deb0ccc3083e713fd7e17a6eab68cf

github-actions[bot] avatar Nov 15 '25 19:11 github-actions[bot]

Code Formatting Check

Great job! Your code is already properly formatted according to our standards:

  • Black formatting
  • Import sorting
  • Ruff checks

No changes needed!

github-actions[bot] avatar Nov 15 '25 20:11 github-actions[bot]

Summary Security Scan Results

All security scans passed!

Scan Type Status
Dependency Scan [SUCCESS] Passed
Code Security [SUCCESS] Passed
Secrets Scan [SUCCESS] Passed

View detailed reports in the workflow artifacts (if available).

[FIX] Workflow Information
  • Workflow Run: #295
  • Triggered by: pull_request
  • Branch: new_cleanup
  • Commit: e2d102e720dadb4c78ff1f98f0d8652796a74ab6

github-actions[bot] avatar Nov 15 '25 20:11 github-actions[bot]