react-tweakpane icon indicating copy to clipboard operation
react-tweakpane copied to clipboard

some updates to hooks

Open lazarusA opened this issue 1 year ago • 1 comments

This is a great project and with a lot of potential. Hopefully it continues to evolve. I tried to update as many things as possible, however, there are two things that really got me.

  1. https://github.com/MelonCode/react-tweakpane/blob/25258dc70cba02b5375335ce70c8793d898dd6d0/src/hooks/usePaneInput.ts#L70
// inputRef.current.controller_.binding.target.write(value) // not longer works
inputRef.current.controller.value.binding.write(value) // proposed solution?

and

  1. https://github.com/MelonCode/react-tweakpane/blob/25258dc70cba02b5375335ce70c8793d898dd6d0/src/hooks/usePaneInput.ts#L91
inputRef.current = input

is not longer valid. Not sure on how to move forward here.

Also, updated dependencies are also missing in this PR.

lazarusA avatar May 15 '24 09:05 lazarusA

all the changes here, work in my local dev app. So, I guess there is no issues then 😄 .

lazarusA avatar May 15 '24 11:05 lazarusA

Thank you for the update, I didn't had a lot of time for support recently 🙏

MelonCode avatar Aug 26 '24 19:08 MelonCode

Will post update to NPM in near time

MelonCode avatar Aug 26 '24 19:08 MelonCode

ohh... I did some more, but didn't push, I should do a new PR then, with the latest.

lazarusA avatar Sep 19 '24 09:09 lazarusA