Milan Miladinovic
Milan Miladinovic
Closing for now as this seems to have been resolved. Feel free to reopen if still experiencing a segfault after `[email protected]` and `[email protected]`. Thanks all for the helpful comments +...
I turned the 2nd commit into a fixup because I resolved the TODOs I had and the rest of it was very small. Will get to the other comments that...
FYI @a-robinson I'm going to push up some new work as a third commit today, with the eventual goal of squashing the commits into 1 before we finally merge this....
Hey @DylanRJohnston, I commented on the previous PR about `state.getTags(ws)`. You [previously asked](https://github.com/cloudflare/workers-rs/pull/434#issuecomment-1894841116) which version of wrangler supported it and I believe it should be [[email protected]](https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%403.26.0).
I believe this has been fixed as of https://github.com/cloudflare/workerd/issues/1422#issuecomment-2075680936, so feel free to close the issue.
The latest commit https://github.com/cloudflare/workerd/pull/1916/commits/00ba98560d35f0f7fe216b989ec17f4d07eec522 uncomments the "getMultiple hard fail" test and attempts to address the reason for the test failure, but for some reason the exception seems to be causing...
https://github.com/cloudflare/workerd/compare/00ba98560d35f0f7fe216b989ec17f4d07eec522..7f5b18fac3bab8fc6901ba1345a82b4ad0df709d is a rebase near or on `main` since this work might be paused for a bit.