libvma icon indicating copy to clipboard operation
libvma copied to clipboard

issue: 3465282 Fix IB clock converter inaccuracy

Open agalanin-at-nvidia opened this issue 1 year ago • 1 comments

Description

Use proper multiplier while converting HCA core clock frequency into Hz.

What

Fix IB clock converter inaccuracy

Why ?

Invalid value for hca core clock frequency was used in time_converter_ib_ctx::calculate_delta.

How ?

We used hca_core_clock for clock conversion from HW timestamp to system clock. But the value for hca_core_clock variable is converted from device capabilities as it's in MHz (multiplied to 1000000=USEC_PER_SEC). That's look wrong because ibv_device_attr_ex.hca_core_clock is in Khz.

Change type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Tests
  • [ ] Other

Check list

  • [+] Code follows the style de facto guidelines of this project
  • [+] Comments have been inserted in hard to understand places
  • [-] Documentation has been updated (if necessary)
  • [-] Test has been added (if possible)

agalanin-at-nvidia avatar May 10 '23 16:05 agalanin-at-nvidia

Can one of the admins verify this patch?

swx-jenkins5 avatar Jun 27 '24 13:06 swx-jenkins5