ib-kubernetes icon indicating copy to clipboard operation
ib-kubernetes copied to clipboard

Wrong usage of log.Err() method

Open DmytroLinkin opened this issue 5 years ago • 2 comments
trafficstars

From source:

// Err starts a new message with error level with err as a field if not nil or
// with info level if err is nil.
//
// You must call Msg on the returned event in order to send the event.
func Err(err error) *zerolog.Event {
        return Logger.Err(err)
}

To get desired logging every log.Err(err) line should be changed to log.Error().Msgf("%v", err)

DmytroLinkin avatar Jul 29 '20 09:07 DmytroLinkin

alternatively: log.Err(err).Msg("") or log.Err(err).Send()

adrianchiris avatar Jul 29 '20 11:07 adrianchiris

log.Err(err).Msg("")

This form produce line with some "technical" noise, something like: ERR "error": some text describing error

DmytroLinkin avatar Jul 29 '20 11:07 DmytroLinkin