Melanie Sumner

Results 243 comments of Melanie Sumner

To expand on this a little bit- it's now in our branding guide. We'll also need to think about how this changes the variations, e.g., ```css --color-brand: #e04e39; /* this...

@mansona do you know what the original calculations were for deciding these shades/tints? I'd like to get this shipped so we can get the upgrades into the other apps.

Well if we aren't able to get this information, let me see if I can figure out what math was used, so we can get this shipped by EmberConf @MinThaMie

Should Ember support this? Opening a modal should be done with a button, not a link.

Clarifying question: why not use grid css? There doesn’t seem to be anymore explicit need for tables or grid roles for layout anymore.

I wonder, in what ways does it matter if some browsers alias the "incorrect" spelling? It's probably okay that there's a test that points this specific use case out, mostly...

@dependabot rebase

@MelSumner note for myself to rebase and also address comments that don't have suggestions.

@aleventhal tagged you in the PR so you can let me know if I have accurately captured your requested text update.

I don't think we need the dummy app anymore TBQH.