Meir Blachman
Meir Blachman
not sure if this would affect the fix but this reproduces for both `XMLHttpRequest` and `fetch`
@zhanzhenzhen can you add some code to show your scenario?
@ariya @ljqx I think this can be closed now
@jogibear9988 is this supported in https://github.com/node-projects/esprima-next ?
@lucivpav I just ran into this issue too. I found a solution for this - https://github.com/estools/escodegen/blob/ab53cd5489fd15c3624386465d1f7a0544cda6c8/escodegen.js#L946-L949 this should be ```js var strExpr = expr.toString(); if (strExpr[0] === '{' || strExpr[strExpr.length...
@lucivpav a better solution is to check the node types: ```js if (node.type === Syntax.ArrowFunctionExpression && node.body.type === Syntax.ObjectExpression) { expr = ['(', expr, ')']; } ```
the more problematic scenario is when having an arrow function returning an object expression in this scenario the generated code is actually invalid ```js () => ( // comment {...
where would this link make sense? we could just modify the title to be a link to github (in the main page https://www.puppeteersharp.com/)
I'm ok with making puppeteer-sharp use strong naming. as long as we check-in the strong-name key file
Or we can reference puppeteersharp as a project reference instead of a package reference