quantum-core-x icon indicating copy to clipboard operation
quantum-core-x copied to clipboard
verified publisher icon MeikelLP

feat(game): guilds

Open MeikelLP opened this issue 1 year ago • 3 comments

Supersedes #12

  • [x] Create Guilds
  • [x] Delete Guilds
  • [x] Invite To Guilds
  • [x] Leave Guilds
  • [x] Guild Leaders
  • [x] Guild Roles
  • [x] View Guild Info
    • [x] Guild News
    • [x] Guild Members
    • [x] Guild Ranks
  • [x] Friend List Guild Members
  • [x] Permissions
  • [x] Spend Exp / Guild Leveling

Additional changes

  • feat: Allow constants and calculations in FieldAttribute.Length
  • fix: not able to inject scoped service into command handlers

MeikelLP avatar May 12 '24 23:05 MeikelLP

Quality Gate Failed Quality Gate failed

Failed conditions
46.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 19 '24 09:05 sonarqubecloud[bot]

Oh boy, that was a long read :) I also tested and it looks good. 👍

It's fine if you don't read all of it. It's a lot but I thought that's better than something half baked. Also at some point I didn't care too much about performance or code quality but rather getting the feature ready. Polishing can be done in subsequent PRs/features/fixes 👍

MeikelLP avatar Oct 07 '24 08:10 MeikelLP

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Nov 04 '24 19:11 sonarqubecloud[bot]