YOLOX icon indicating copy to clipboard operation
YOLOX copied to clipboard

Published 20 hours ago • verified publisher icon Megvii-BaseDetection

upgrade onnxsim to v0.4.1

Open daquexian opened this issue 3 years ago • 6 comments

I'm the author of onnx-simplifier. Recently I published onnxsim v0.4.1. In the latest version, dynamic input shapes are natively supported with no need for extra flags like dynamic_input_shapes and input_shapes.

daquexian avatar Jul 19 '22 07:07 daquexian

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 19 '22 07:07 CLAassistant

Thanks for your contribution @daquexian , Plz lint your code to pass the workflow. BTW, have your ever double checked exported onnx model ?

FateScript avatar Jul 19 '22 08:07 FateScript

@FateScript Fixed.

I haven't checked the exported model because I'm not familiar with the usage. Could you please help check it if there is some concern?

daquexian avatar Jul 19 '22 08:07 daquexian

@FateScript Fixed.

Could you please help check it if there is some concern?

Ok, I will check this later. Plz remind me if this PR is not merged for a week. Thanks.

FateScript avatar Jul 19 '22 09:07 FateScript

@FateScript Fixed. Could you please help check it if there is some concern?

Ok, I will check this later. Plz remind me if this PR is not merged for a week. Thanks.

All right. Thanks!

daquexian avatar Jul 19 '22 09:07 daquexian

@FateScript what is the status of this PR?

tadejsv avatar Aug 14 '22 12:08 tadejsv

@FateScript what is the status of this PR?

@tadejsv I have checked the onnx generated by this pr and it works. I will merge this PR ASAP.

FateScript avatar Dec 26 '22 02:12 FateScript

LGTM. Thanks for your contribution @daquexian .

FateScript avatar Dec 26 '22 02:12 FateScript