megumin

Results 41 comments of megumin

I noticed that the edition guide for unsafe attributes got [merged](https://github.com/ehuss/edition-guide/blob/b80cba8af64a9c52d56f7081c764e5396e406f6c/src/rust-2024/unsafe-attributes.md). It says that `export_name` must be marked as `unsafe`. I think that if this is the case, `export_ordinal` should...

It's entirely possible that a dependency could mark something as a duplicate ordinal, so I believe the same risks apply. I'm not sure whether to word it as "in 2024...

Thanks for the clarification. I'll work on the changes in a bit.

I have updated the RFC to mark `export_ordinal` as unsafe. I have also removed the section on re-exporting bindings, as after testing, I've confirmed that this is not valid code.

Is there anything I could do to help move this along?

@not-a-cowfr this is really nice, thanks! As for the bitflags macro, I think that's a good idea - you should def include that. In regards to not having `enum_number`, ~~we...

> was there any actual point in changing the languageConfig to tsx Realistically I could've put the colours in the Rust.tsx, but I thought it would be good in case...

@mtijanic apologies for not following the template - I opened the issue from the line of code where the error occurred, so didn't get shown the template flow. I just...

Switching TTY sometimes works for me, but other times it just freezes my whole system 😔

@mtijanic just wondering if you managed to spot anything? No worries if you haven't gotten around to it yet though :)