#4063 Add safe invocation on JavaScript Modules

[njannink]

[njannink]

@stsrki I updated the checks

[David-Moreira]

@njannink Can you provide the steps to reproduce the error, I am unable to reproduce with our master branch.

[David-Moreira]

PS: Our master branch has a new PR merged that deals with disposables. I am not sure if it's going to have an impact here. #4103

[stsrki]

After I've changed the JSClosableModule with the safe-invocation, I cannot reproduce errors anymore. Tested in Chrome with 3G network option. @njannink Can you test again on your side?

It might be worth updating other JS modules with the same code.

[stsrki]

All modules updated.

[njannink]

Sorry I did not have time to look at it the last weeks. I will see if I can check next week

[stsrki]

Sorry I did not have time to look at it the last weeks. I will see if I can check next week

Thanks. On Tuesday, we plan to release v1.1, so it would be great to have it confirmed by then :)

Have a lovely weekend :)

[stsrki]

Hey @njannink, were you able to test this PR?

[njannink]

I can still reproduce the issue with version 1.1.1 of Blazorise, but I guess its not merged yet to that branch

[njannink]

[stsrki]

It's still umerged on the 1.0 branch.

[njannink]

so no way for me to really test it in my setup. I did a code review and that looked fine

[stsrki]

so no way for me to really test it in my setup. I did a code review and that looked fine

You're already moved to 1.1 with your project?

[njannink]

Yes I migrated to 1.1.1 for our dev environment. Our production is still 1.0. But since this exception is not really a blocker its fine to fix it for 1.1