Blazorise icon indicating copy to clipboard operation
Blazorise copied to clipboard

Published 20 hours ago • verified publisher icon Megabit

Progress supports ElementId

Open blake-fm opened this issue 2 years ago • 1 comments

Nothing major - just added support for HTML id attr (via ElementId) to <Progress>.

Supremely untested, outside of Blazorise.Bulma. Please feel free to fix/edit as you please.

blake-fm avatar Aug 11 '22 12:08 blake-fm

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Aug 11 '22 12:08 github-actions[bot]

Thank you for the sumbission. I have made some fixes on where to apply the element id. Our general rule is to apply it to the element that has class="@ClassNames" style="@StyleNames" as we consider it the main target when there are many elements to consider.

Before I merge, I would ask you if that solution would work for you.

stsrki avatar Aug 12 '22 13:08 stsrki

PS. can you comment with I have read the CLA Document and I hereby sign the CLA?

stsrki avatar Aug 12 '22 13:08 stsrki

Thank you for the sumbission. I have made some fixes on where to apply the element id. Our general rule is to apply it to the element that has class="@ClassNames" style="@StyleNames" as we consider it the main target when there are many elements to consider.

Before I merge, I would ask you if that solution would work for you.

Apologies; yes, that is perfect. I fixed this for myself (Bulma), and skim-read / hurriedly impl. for the greater Blazorise library, without verifying anything. Bad form on my part. Should have just raised an issue with the suggestion.

RE: signing the CLA, unfortunately right now that is going to take some time (long, legal story). I am happy to designate this code (the few characters of it) to public domain, provided that would not cause issues for you.

Also happy for you to simply close the PR and implement an identical change; my goal here was purely to save you some time. This suggested change is yours to do with as you please.

blake-fm avatar Aug 12 '22 13:08 blake-fm

Ok, I will keep this open for a few days, and if nothing changes regarding the CLA, I will close and re-implement my own changes.

Thanks

stsrki avatar Aug 12 '22 13:08 stsrki

All is good with the PR. but closing because of the legal issues. We will make the changes by ourselves.

Thanks @blake-fm

stsrki avatar Aug 16 '22 10:08 stsrki