Meeth
Meeth
Hi @mon4our can you PTAL whenever you have time . Thank you so much. Regards, Meeth.
https://github.com/oppia/oppia/issues/24219 I mention ed this flake in this issue .
Registered first flake at :https://github.com/oppia/oppia/issues/24262 Registered second flake at : https://github.com/oppia/oppia/issues/24259 Registered Third flake at : https://github.com/oppia/oppia/issues/24261 Registered Last Flake at : https://github.com/oppia/oppia/issues/24258
@mon4our can u PTAL whenever you have time . Thanks !! Regards, Meeth
@NITISH084 hi sir , I think the above ci acceptance failing is a flake . Secondly I did add only one thing that is event.preventDefault to persist the state of...
Hi @mon4our thank you so much for the review and guiding me on how to proceed with adding the event.preventDefault in the addToLearnerGoals function in the component file . I...
Hi @mon4our I am getting the error of the coverage of the test not passing even though I have added the test for the code can you PTAL at that...
Hi @mon4our I actually didnt provide the coverage reports and hence below the coverage reports is mentioned. In this image as u can see that the goals-tab.component.ts is almost 100%...
Hi @mon4our thank you so much for the review . In the above image you will be able to see that it is saying I have not coverd the event.preventDefault()...
@mon4our Hi can you PTAL at the above comment whenever you have time , and guide me on what needs to be added more ?? Thank you so much for...