t1-python icon indicating copy to clipboard operation
t1-python copied to clipboard

Missing Margin Entity

Open FodT opened this issue 9 years ago • 5 comments

A todo of missing entities in SDK

  • Margin (campaign_margin_calc)
  • ~~SupplySource~~
  • ~~VendorContract~~
  • ~~VendorDomain~~
  • ~~VendorPixel~~
  • ~~VendorPixelDomain~~
  • ~~Vertical~~

FodT avatar Aug 20 '15 15:08 FodT

  • Audience segments

pswaminathan avatar Aug 25 '15 20:08 pswaminathan

  • Margin (campaign_margin_calc)

pswaminathan avatar Dec 18 '15 17:12 pswaminathan

Vertical, Audience Segment and Supply Source were added by https://github.com/MediaMath/t1-python/pull/48

FodT avatar Jan 26 '16 10:01 FodT

the campaign/:id/margins endpoint still returns the legacy xml->json converted format:

      "prop": [
        {
          "value": "123456",
          "name": "campaign_id"
        },
        {
          "value": "2017-01-19T00:00:00",
          "name": "margin_date"
        },
        {
          "value": "85.0000",
          "name": "margin_pct"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "created_on"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "updated_on"
        }
      ],
      "name": "campaign Margin 2017-01-19",
      "id": 1542715,
      "type": "campaign_margins_calc"
    }

we'll need this to be consistent with the rest of the json responses before we can add support.

FodT avatar Jan 25 '17 11:01 FodT

Related to CAW-3810 (internal)

fsargent avatar Jan 25 '17 17:01 fsargent