MediaInfoLib
MediaInfoLib copied to clipboard
Consistency of shared lib name in CMakeList and MediaInfoDLL.h
CMakeLists adds a postfix to debug libs if Windows or Apple OS, but shared build is broken with this postfix, since shared lib name is also hardcoded in MediaInfoDLL.h without this postfix. They are not consistent:
https://github.com/MediaArea/MediaInfoLib/blob/31752cdea997f2d27bd6996c2268a4d9fe6446ec/Project/CMake/CMakeLists.txt#L80-L85
https://github.com/MediaArea/MediaInfoLib/blob/31752cdea997f2d27bd6996c2268a4d9fe6446ec/Source/MediaInfoDLL/MediaInfoDLL.h#L120-L137
Postfix could be removed, it's not required.
Moreover, current CMakeLists generates a lowercase dll name (mediainfo.dll instead of MediaInfo.dll), but it's harmless since Windows is case insensitive.