vedaseg icon indicating copy to clipboard operation
vedaseg copied to clipboard

Why are there so many methods, and even some file have only one method

Open Czshippee opened this issue 2 years ago • 2 comments

Why make the code so complicated? I just want to see how you use transforms to augment the image. From the dataset file, I jumped 6 pages and haven't seen the final code so far. . . . .

Czshippee avatar Apr 22 '22 07:04 Czshippee

You have a function called '_build_transform' in class common, and inside the function there is only one line which is return 'build_transform'. After I jump tp that page, there are only one function in this file, and I can see you only call this function once, so why you just put the code inside the '_build_transform '.

Czshippee avatar Apr 22 '22 07:04 Czshippee

Why make the code so complicated? I just want to see how you use transforms to augment the image. From the dataset file, I jumped 6 pages and haven't seen the final code so far. . . . .

Hi,

Thanks for your interest in our Vedaseg.

Our design makes it easier to develop and use in our sense.

You should look at transformes instead of dataset.

FYI, we are building transforms based on albumentations

For the '_build_transform' part you mentioned, you are trapped in our mechanism design. Those designs makes it easier for customization based on your own needs. With those 'extra codes', you can define your experiments by only change the config file instead of changing actual code. You will see it when you see the whole picture.

DarthThomas avatar Apr 22 '22 07:04 DarthThomas