DefDAP icon indicating copy to clipboard operation
DefDAP copied to clipboard

Advanced Notebook example issues: old code and different data

Open Tijmenvermeij opened this issue 2 months ago • 2 comments

Hi guys,

As part of some procrastination efforts I have started to play around a bit with DefDAP, with the ultimate goal of trying to implement the SSLIP algorithm for slip system ID. However, I've had some trouble using advanced_notebook.ipynb as an example.

Is it correct that some of the code in there is from an older version of DefDAP? Also (after using code from example_notebook.ipynb), I tried to use the Zircalloy data (https://data.mendeley.com/datasets/n4cdwp6pwc/1), but I think that the homologous points that are used in the notebook are not correct. It seems that advanced_notebook.ipynb is using different EBSD maps ("irr_new.crc") from the ones in the repository ("irr.crc")... I then wanted to try to define the homologous points myself but the bmp file is too large :)

In the mean time I'll try my best with the FCC example. The reason I'm interested in the Zircalloy is that there seem to be fewer slip systems active so that the verification (and troubleshooting) of my code is a bit easier.

Cheers, Tijmen

Tijmenvermeij avatar Nov 10 '25 17:11 Tijmenvermeij

Hi Tijmen,

Good to hear from you and great to see you are trying to port SSLIP over to python. Last week we ran a HRDIC workshop and so had a push to bring all the unfinished changes into master and make a release, so there was some big changes. I will look into the issues you mentioned when I get change but for now you can grab the workshop package we put together. This has the notebooks from the repo but also some small datasets (Ni, Ti and Zr) to go with them and should all be working. Download here: https://bit.ly/4oqeE2p . You might need to update defdap, the latest version is now 1.0.

Let me know if you have an questions or just to chat about how we could best integrate your algorithm in defdap.

Thanks, Michael

mikesmic avatar Nov 11 '25 09:11 mikesmic

Hi Michael,

Thanks! Those datasets and notebooks seem very useful, I will continue with those!

I think my rough plan is to get some kind of version running and then we can maybe discuss how best to integrate it "properly". I'm not an experience Python user so my coding is not so great probably :)

Cheers, Tijmen

Tijmenvermeij avatar Nov 11 '25 09:11 Tijmenvermeij