Lorenzo comments

Results 200 comments of


                                            Lorenzo

Do you want PR with cuda support?

Thank you, I am taking a look. Just for historical correctness: the library was created by Vlad Orlov, I became maintainer in 2019. You can open a PR and target...

Do you want PR with cuda support?

OK, as you feel comfortable. If you open a PR I can help with the doctrings and the the tests in the meanwhile. EDIT: also this way we can tackle...

Improve performance of SVC

Thanks for finding this. That implementation is old, from before the new Array abstraction had been implemented.

Consider using geometric algebra in a feature flag

https://github.com/smartcorelib/smartcore/issues/292#issuecomment-2844144870

Implement predict_proba for RandomForestClassifier

@morenol could you take a look to the new tests? I get inconsistent errors from some platforms

Trait bounds of RandomForest::fit conflict with those of predict and other metrics

the initial point of view for this was that classification labels need to be integers otherwise which element belongs to which class is ambiguous. Integers have also the advantage to...

Trait bounds of RandomForest::fit conflict with those of predict and other metrics

I understand but this would be a breaking change for existing programs so we need to think through if it is really necessary and eventually how to improve the situation

Trait bounds of RandomForest::fit conflict with those of predict and other metrics

I understand the problem but the solution may not be the one you suggest, so it is better to think about it and find viable options for a long-term solution...

Matrix allocation optimization

i don't think this is the right way to go. Let's think about this for some time to have a better understanding

Matrix allocation optimization

or at least we need a multi-step roadmap to gradually implement this.