meaningfulcode-frontend icon indicating copy to clipboard operation
meaningfulcode-frontend copied to clipboard

Feature: Support internationalization

Open Pixep opened this issue 5 years ago • 6 comments

Add support for internationalization of the frontend, and the possibility to easily extend it for more languages.

Pixep avatar Dec 07 '20 01:12 Pixep

Hey @Pixep I came across meaningfulcode as a website then started working on this feature just to brush up on Next.js. Is it still a thing? If so then I'll be create PR once it's in a acceptable state.

giorgiodg avatar Jul 07 '25 10:07 giorgiodg

Hi @giorgiodg ! Happy to help review & merge if you want to work on it, absolutely. Feel free to ping me on discord if needed too.

Thank you!

Pixep avatar Jul 07 '25 15:07 Pixep

I've raised https://github.com/Meaningful-Code/meaningfulcode-frontend/pull/143 Let me know if it's worth catching up given its length.

Thank you!

giorgiodg avatar Jul 11 '25 15:07 giorgiodg

Hey @Pixep did you have any chance to look at my PR? Next week I'll have quite some time to work on comments in case you have any

giorgiodg avatar Aug 14 '25 15:08 giorgiodg

Hi! And thank you for it! That's a great start.

Two things that I see:

  1. This obfuscates significantly the content of all pages (especially when we have multiple paragraphs and text elements individually translated). Both the intent (if the translation name isn't descriptive enough) and content (length, format). Both these things would make maintenance difficult => The naming is fixable, but I think its a function of the granularity, i.e. the translated items are too granular/small, and become difficult to name. So maybe instead of trying to fit only single text units, this could be larger, like even a set of paragraphs, even if that includes some structure elements (paragraphs, other). => I do not know what are the best practices for translation & internationalization with react/mui, but if you haven't already, I would recommend to see what people say, there might be some nuggets of wisdom

  2. As there is no mechanism to change the language (if I got that right), this would be tricky to test => Maybe we could start with a smaller subset, like adding translations for a single page instead, and change language using the browser's default language? This doesn't even have to be the home page, it might be wise to pick something simpler to get it right.

Let me know if that makes sense!

On Thu, Aug 14, 2025 at 8:03 AM Giorgio Delle Grottaglie < @.***> wrote:

giorgiodg left a comment (Meaningful-Code/meaningfulcode-frontend#2) https://github.com/Meaningful-Code/meaningfulcode-frontend/issues/2#issuecomment-3188786982

Hey @Pixep https://github.com/Pixep did you have any chance to look at my PR? Next week I'll have quite some time to work on comments in case you have any

— Reply to this email directly, view it on GitHub https://github.com/Meaningful-Code/meaningfulcode-frontend/issues/2#issuecomment-3188786982, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN25DC6SOLDJYFGSKKVUN33NSQNXAVCNFSM6AAAAACA52V3P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBYG44DMOJYGI . You are receiving this because you were mentioned.Message ID: @.***>

Pixep avatar Aug 14 '25 15:08 Pixep

I'll unpack this comment and reply to each of the items likely early next week!

giorgiodg avatar Aug 16 '25 14:08 giorgiodg