Sunflower icon indicating copy to clipboard operation
Sunflower copied to clipboard

Published 20 hours ago • verified publisher icon MeanEYE

Fix opening file from URI

Open joshas opened this issue 4 years ago • 3 comments

My attempt to fix #419 . Only tested with FTP provider and local provider. Also tested with file names containing spaces on FTP - no problems with opening them.

joshas avatar Oct 15 '20 18:10 joshas

Am not sure this will work with all the cases.

MeanEYE avatar Oct 16 '20 11:10 MeanEYE

I presume there are only two types of paths: local (ones without ://, like /usr/local/bin/) and URI (ftp://, smb://, etc). What other cases should I try to test? I'll try to set up connections to real protocols and test with them. Any corner cases that I should be aware of, e.g. illegal symbols, spaces in file names?

joshas avatar Oct 16 '20 16:10 joshas

Unicode characters, symbols, etc. Without encode path I feel it might fail but do test and let me know. I could very well be wrong.

MeanEYE avatar Oct 17 '20 06:10 MeanEYE