Sunflower icon indicating copy to clipboard operation
Sunflower copied to clipboard

Pressing enter from quick search containing ".." does not change current directory.

Open MAWSpitau opened this issue 6 years ago • 6 comments

Hi there,

I like to walk trough my dirs with the keyboard. Searching for dirs and file with just typing in the thing I want works pretty cool, but to go to a parent dir by just typing ".."+ enter does not work.

After typing .. nothing happens :( That makes my sad ;)

I would prefer the ".." would be handled like a normal path.

Thanks for sunflower!

MAW

MAWSpitau avatar Dec 06 '17 09:12 MAWSpitau

Can you give me more information about what happens. By typing .. are you invoking quick search, or entering a command?

MeanEYE avatar Dec 06 '17 10:12 MeanEYE

And you are welcome! :)

MeanEYE avatar Dec 06 '17 10:12 MeanEYE

I sent a mail as a reply, but it seems it will not get here ;)

So:

it opens the Searchbox at the end. But it will not go into the parent dir... For better understanding, there is a little Screencast.

https://www.dropbox.com/s/1204a1m3em3s9te/sunflowerProblem.mkv?dl=0

Thanks a lot Marcel

MAWSpitau avatar Dec 06 '17 10:12 MAWSpitau

Oooh, that's a strange one. It should absolutely do that. Thanks for reporting it. I'll fix it!

MeanEYE avatar Dec 06 '17 11:12 MeanEYE

There's a check that prevents going up to parent directory if quick search is active: https://github.com/MeanEYE/Sunflower/blob/6b4aef4fca2506912f1f14ec4a7e8e68f49b42ae/sunflower/plugin_base/item_list.py#L1236-L1239

I guess this was included to prevent going up directories when pressing Backspace key.

joshas avatar May 06 '20 19:05 joshas

Hm, right you are. This check is there so Backspace could work. But it's preventing the regular move to parent directory as well. Good catch @joshas.

MeanEYE avatar May 06 '20 21:05 MeanEYE