Mmadu Manasseh
Mmadu Manasseh
This is because we run `git diff origin/ --name-only` to generate the list of files modified in a PR. The diff command here compares changes/commits in the HEAD branch that's...
@stevehipwell to answer your question to https://github.com/stevehipwell/helm-charts/pull/835#issuecomment-1836351273, trying to do that makes the chart complex and difficult to read. Creating a different sharded manifest for the shards makes it easier...
@stevehipwell this change is now ready. When you get some time kindly review, thanks!
@stevehipwell I'm rethinking the strategy for this. Why: 1. having shards means we'll need to allow modifying all the specs for each shards e.g resources, affinity etc. 2. [This PR...
yeah, feels like kubechecks shouldn't comment on repos with no argocd apps. I don't think it's a bug thought, it's an enhancement. Kubechecks does what it's meant to do; listen...
@andridzi thanks for the PR. I've dropped a few changes. Please take a look
@andridzi that's for adding the changes. the only thing left for this is https://github.com/zapier/kubechecks/pull/301#discussion_r2028616667. Can you take a look when you have the time?
@duckaraptor you need to bump the helm chart version by one patch version
@duckaraptor could you please fix the CI errors ?