Míguel Ángel Mulero Martínez
Míguel Ángel Mulero Martínez
> I've just released version 1.1.17 for openwrt_luci_rpc to fix above issue. > > Tomorrow I will submit a PR to home-assistant. Goodnight everyone. Hi! Did you submit the PR?...
I think I've been able to reproduce the problem... Executing: ``` service ddns reload ``` reproduces the problem.
More info: looking at the code, there is a `killall` command: ``` killall -1 dynamic_dns_updater.sh 2>/dev/null ``` https://github.com/openwrt/packages/blob/f9c90fce0aad9ebec04e09b10843da3571c09f83/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh#L92C3-L92C48 This command seems to produce the problem. If I remove the `-1`...
I don't see it a bad idea. It simply tries to "kill" all instances to restart all of them. I saw the -1 was added some years ago, the strange...
I've done more tests and it's the killall with the -1 who duplicates the processes. It seems when it receives the sighup it creates another process without dying.
@maxberger some advance on this? If not, at least as workaround, we can remove the "-1", it seems to work and not duplicates the processes.
I know is out of this "refactor" but as suggestion for the future, the major part of DDNS providers let update the IPv4 and IPv6 at the same time. It...
> > Thanks for the commit! Please limit your line-length to 80 chars. > > @aparcar For clarity, you're referring to the line length within the file I committed? If...
I see it merged in master.
You are right. Something is wrong with the addon to create this big file. I'm not too sure what is the origin of the problem right now.