mbin icon indicating copy to clipboard operation
mbin copied to clipboard

Article thumbnails no longer present

Open e-five256 opened this issue 10 months ago • 5 comments

Describe the bug

Incoming article thumbnails are no longer present

Compare https://kbin.run/d/theguardian.com https://fedia.io/d/theguardian.com

https://kbin.run/d/bloomberg.com https://fedia.io/d/bloomberg.com

On which Mbin instance did you find the bug? kbin.run

Which Mbin version was running on the instance? >1.5.2

Expected behavior Article entries to have thumbnails

Screenshots

kbin.run fedia.io
image image

e-five256 avatar Apr 08 '24 19:04 e-five256

kbin.run almost always runs the latest main (and sometimes experimental PRs...), but I'm guessing this issue is related to https://github.com/MbinOrg/mbin/pull/650. thoughts, @asdfzdfj? if you need more info let me know what to pull out of the logs and/or database.

ghost avatar Apr 09 '24 01:04 ghost

kbin.run almost always runs the latest main (and sometimes experimental PRs...), but I'm guessing this issue is related to #650. thoughts, @asdfzdfj? if you need more info let me know what to pull out of the logs and/or database.

if possible, could you sample some error logs for EntryEmbedMessage or AttachEntryEmbedHandler and nearby that uses/mentions the affected link that's missing the cover? also, if you have debug log enabled (somehow), try to search for Embed:fetch: fetch success in them that mentions the affected url, thanks

I think I got at least one way it failed which should explains the guardian case but does not for bloomberg, so there may be more way things went wrong, the proposed fix for this is in #695

EDIT: for kbin.run and bloomberg, it looks like the cover thumbnail for these was flaky since at least a month ago (as of writing 2024-04-09, try checking around page 5/6), so this might point to connectivity issues between these 2 domains, and thus the cover attach doesn't work properly because it failed to fetch bloomberg's data

asdfzdfj avatar Apr 09 '24 07:04 asdfzdfj

That seems to have helped https://kbin.run/d/theguardian.com/newest

But https://kbin.run/d/bloomberg.com/newest and https://kbin.run/d/thehill.com/newest still no dice while they appear to work fine in 1.5.2

e-five256 avatar Apr 09 '24 19:04 e-five256

I see what you're saying that it might be non-mbin problem. Let me try to consolidate some stats on who thehill.com thumbnails work for

❌ - debounced ❌ - melroy ❌ - thepaperpilot :ballot_box_with_check: - jerry :ballot_box_with_check: - benti (both instances) :ballot_box_with_check: - mozz :ballot_box_with_check: - lucifier

Well, interesting data I guess

e-five256 avatar Apr 09 '24 19:04 e-five256

Based on https://news.ycombinator.com/item?id=19093945 it seems other sites also have trouble getting content from bloomberg, perhaps I will close this as not something mbin can do anything about if people think that is accurate

e-five256 avatar Apr 09 '24 20:04 e-five256

This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days.

github-actions[bot] avatar May 31 '24 02:05 github-actions[bot]

It looks like thumbnails stopped appearing on fedia for bloomberg and thehill 4 weeks ago for both. There wasn't an mbin release during that timeframe, so perhaps it is unrelated to mbin, but as there isn't enough info, I'm just going to close this for now

e-five256 avatar Jun 04 '24 23:06 e-five256