mbin
mbin copied to clipboard
Remove entry component from edit thread + fix top-margin
- Removed entry component from edit thread page, seems like an old-school copy/paste error (it also caused JS errors)
- Add top margin via
section--topclass - Fix integration test
- Solve conflict within the
_section.scssfile trying to enforce amargin-top: 0 !important;, which doesn't allow us to set an actual top-margin on.section--top, which are defined in _layout.scss but was never getting applied correctly ....
The latter fix with margin-top also solves issues on other pages like the microblog post will now have finally the correct top margin getting applied (which is an long standing issue):
| Before | After |
|---|---|
But the main change of course is:
| Before | After |
|---|---|
Basically similar to other edit pages like the magazine edit page:
(yes I cancelled the workflow on purpose.. I will need to rebase again again.. so I the update rebase will trigger again a new workflow run..)