MBin not resolving remote user: @[email protected]
Describe the bug Lemmy users with underscores in their usernames don't appear to be visible from Fedia. This is possibly impacting federation of their comments.
On which Mbin instance did you find the bug? fedia.io
Which Mbin version was running on the instance? 1.8.4
To Reproduce Steps to reproduce the behaviour:
- Go to https://fedia.io/u/@[email protected]
- See error
Expected behaviour Expecting all users to resolve.
Screenshots If applicable, add screenshots to help explain your problem.
This is from a mod list on a remote magazines, it hasn't picked up the avatar of the underscore users:
Same from a local magazine:
Underscore users show up as 404 when clicked:
Desktop (please complete the following information):
- OS: Raspberry Pi OS
- Browser: Firefox
- Browser Version: 142.0.1
Additional context A couple of relevant threads where an issue was picked up:
https://fedia.io/m/fedia/t/2798884/comments-in-reply-to-my-post-concealed-from-me
https://feddit.uk/post/37116728/20560617
Usernames with underscores do work in my case, eg: https://kbin.melroy.org/u/@[email protected]
Does not give 404:
Another example of mine:
So that seems a bit inconsistent with your findings. Most likely the remote user just has not been fetched.
Odd, I tested your feddit.it user on fedia and it did indeed display.
I can search for my feddit.uk one and it comes up, but I can't progress any further. I've just followed it in case that was part of the problem, but it doesn't appear to have helped.
Yeah something is still wrong. I can actually replicate the issue on my server: https://kbin.melroy.org/u/@[email protected]
EDIT: It could also trigger this code for some reason: https://github.com/MbinOrg/mbin/blob/main/src/Controller/User/UserFrontController.php#L53
if ($user->isDeleted && (!$requestedByUser || (!$requestedByUser->isAdmin() && !$requestedByUser->isModerator()) || null === $user->markedForDeletionAt)) {
throw $this->createNotFoundException();
}
Finally, I think something goes wrong with fetching the user as well.. Like its missing the avatar icon.. While clearly he has set one: https://feddit.uk/u/i_am_not_a_robot
I noticed some columns are also NULL:
I found the same username on another instance (it doesn't need to be the same user though), also with multiple underscores.. but retrieving that user goes fine @[email protected].. Meaning its not the underscores.