mbin icon indicating copy to clipboard operation
mbin copied to clipboard

Update messages.en.yaml

Open TheVillageGuy opened this issue 10 months ago • 5 comments

Shorten subscribe/unsubscribe to prevent buttons forming two rows

TheVillageGuy avatar Feb 06 '25 12:02 TheVillageGuy

Not sure why the integration tests are failing. Anyhow, you could also change it here: https://hosted.weblate.org/engage/mbin/ and sync it back. But both works.

melroy89 avatar Feb 06 '25 16:02 melroy89

Also we might still want to show the full line "Subscribe" and "Unsubscribe" to the users when they mouse-over the button, using the HTML title tag. Hence it might be better to create a new translation strings for the abbreviations.

melroy89 avatar Feb 06 '25 16:02 melroy89

@TheVillageGuy some tests do use text to recognize some buttons so when you change it it will not find those buttons anymore and then you'll get errors like "current node list is empty". When you go to the failed pipeline you will get the test errors with the files they originate from. Then you can fix them

BentiGorlich avatar Feb 06 '25 19:02 BentiGorlich

Also we might still want to show the full line "Subscribe" and "Unsubscribe" to the users when they mouse-over the button, using the HTML title tag. Hence it might be better to create a new translation strings for the abbreviations.

Good point, I'll add them soon.

@BentiGorlich I'm going to have to figure out how those tests work then, that's going to take some time

TheVillageGuy avatar Feb 11 '25 14:02 TheVillageGuy

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Mar 24 '25 02:03 github-actions[bot]