mbin icon indicating copy to clipboard operation
mbin copied to clipboard

Get rid of simple-icons-font?

Open melroy89 opened this issue 10 months ago • 3 comments

Is your feature request related to a problem? Please describe.

Get rid of the simple-icons-font package. Since it will add a lot of icons and therefor more MBs to the overall size of the bundle.

Currently, we do use it. But apparently only at two places:

https://github.com/MbinOrg/mbin/blob/d7ed2a837735b864467590d9229d3b33b48d8012/templates/components/login_socials.html.twig#L29 https://github.com/MbinOrg/mbin/blob/d7ed2a837735b864467590d9229d3b33b48d8012/templates/components/login_socials.html.twig#L37

Describe the solution you'd like

Let's see if we can leverage existing icon sets we already have like Font awesome.

Describe alternatives you've considered

Keep it as is?

Additional context

Brought up during PR: https://github.com/MbinOrg/mbin/pull/1417

melroy89 avatar Feb 04 '25 01:02 melroy89

There is another alternative, which is using https://icomoon.io/.

That site allows you to cherry pick icons. And bundle & package only the icons you really need!

melroy89 avatar Feb 04 '25 01:02 melroy89

See https://github.com/simple-icons/simple-icons-font?tab=readme-ov-file#custom-builds

You can custom-build the font file as you want.

LitoMore avatar Feb 09 '25 19:02 LitoMore

See https://github.com/simple-icons/simple-icons-font?tab=readme-ov-file#custom-builds

You can custom-build the font file as you want.

Thanks, that is also a possibility if these icons are not in Fontawesome or we don't want to use icomoon. Thanks for bringing this up.

melroy89 avatar Feb 09 '25 19:02 melroy89