mbin icon indicating copy to clipboard operation
mbin copied to clipboard
verified publisher icon MbinOrg

Related links

Open JaviviJR opened this issue 1 year ago • 15 comments

Added new dynamic field in profile section witch let us to add related links.

https://github.com/MbinOrg/mbin/issues/839

imagen

JaviviJR avatar Aug 22 '24 16:08 JaviviJR

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field. grafik

BentiGorlich avatar Sep 03 '24 07:09 BentiGorlich

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field. grafik

Do you want that user can add just links or whatever data user wants like Mastodon?

JaviviJR avatar Sep 03 '24 10:09 JaviviJR

Limit it to links would be fine for me, but I don't think that it makes sense :thinking:

BentiGorlich avatar Sep 04 '24 08:09 BentiGorlich

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field. grafik

Agreed that would be helpful, so it's basically a key/value list.

melroy89 avatar Sep 07 '24 13:09 melroy89

Oh and please change the target of the PR to dev/new_features

BentiGorlich avatar Sep 12 '24 17:09 BentiGorlich

I'd love if the add button would something like this (but that is not a requirement): grafik

I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR? (The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)

imagen

Check it out with the new changes. I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

Also I modified userBox component to show related links in profile.

imagen

JaviviJR avatar Sep 16 '24 19:09 JaviviJR

First of all thanks for your time and effort :heart: I will have a look at it in the next days.

From your comment and screenshots I (already) have a few remarks (sorry :see_no_evil:):

I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

I think I did it by making a div with a margin left the same size as the buttons and then just put text-align: center in there.

I modified userBox component to show related links in profile.

What happens when the value is not a link?

BentiGorlich avatar Sep 16 '24 20:09 BentiGorlich

There is a conflict with translations/messages.es.yaml. Ideally only change the English language file. And translate the rest in Weblate.

melroy89 avatar Sep 16 '24 20:09 melroy89

could you rebase your branch on dev/new_features please so the github actions are triggered? We forgot to update the config for that :)

BentiGorlich avatar Sep 27 '24 16:09 BentiGorlich

Also there is file conflicts xd again? Sorry about that.

melroy89 avatar Sep 27 '24 17:09 melroy89

Fixed merge conflicts..

melroy89 avatar Nov 08 '24 13:11 melroy89

Fix the php-cs-fixer

melroy89 avatar Nov 08 '24 13:11 melroy89

PR should be ready for last review now.. I hope. 🥳

melroy89 avatar Nov 08 '24 13:11 melroy89

@JaviviJR did you push all your changes? The modifications of the edit profile page and the user box are not there, yet

BentiGorlich avatar Nov 24 '24 14:11 BentiGorlich

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Mar 21 '25 02:03 github-actions[bot]