mbin icon indicating copy to clipboard operation
mbin copied to clipboard

Allow admins to view user IP addresses in the admin panel users table and users page

Open ghost opened this issue 1 year ago • 9 comments

Introduces admin ability to view local users IP addresses as resolved from src/Service/IpResolver.php:

image

A user's IP address is updated on:

  • [x] successful authentication
  • [x] entry creation
  • [x] entry edit
  • [x] entry comment creation
  • [x] entry comment edit
  • [x] post creation
  • [x] post edit
  • [x] post comment creation
  • [x] post comment edit

I also added local user email and IP to the user's page for admins:

image

Other things: I noticed the GitHub authenticator was missing the IP being set in the user dto which will cause the registration limiter to be ineffective, so I added it in to be consistent with the other authentication mechanisms.

Closes: https://github.com/MbinOrg/mbin/issues/833

ghost avatar Aug 09 '24 03:08 ghost

I thought that we fixed the trusted proxy problem a long time ago :O

BentiGorlich avatar Aug 09 '24 14:08 BentiGorlich

I thought that we fixed the trusted proxy problem a long time ago :O

not sure how since it was never configured, lol

ghost avatar Aug 09 '24 14:08 ghost

Should we follow-up this PR?

melroy89 avatar Sep 22 '24 12:09 melroy89

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Nov 02 '24 02:11 github-actions[bot]

Rebased..

melroy89 avatar Nov 08 '24 13:11 melroy89

Fixed PHP cs fixer.

melroy89 avatar Nov 08 '24 20:11 melroy89

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Jan 02 '25 02:01 github-actions[bot]

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Jun 10 '25 03:06 github-actions[bot]

This PR is stale because it has been open 40 days with no activity.

github-actions[bot] avatar Jul 21 '25 03:07 github-actions[bot]