mbedtls
mbedtls copied to clipboard
Mbed-TLS
PR-Template: Updated the PR template with new checkboxes
Description
Updates the development branch's PR checkboxes as discussed in PR #9008. Will need to apply for 3.6 and 2.28 braches as well before merging.
You can see the template live at https://github.com/minosgalanakis/mbedtls/compare/feature/crypto_client_testing_base...minosgalanakis:mbedtls:dev_fix_checkboxes
Will need to apply for 3.6 and 2.28 braches as well before merging.
No: the template is only ever read from the default branch. We can't have different templates based on a pull request's target branch.
Note: after merging this, we'll want to merge development to development-restricted (the default branch of the restricted repo) so that the new template is used there as well.
the fact the checking the boxes should be done by the gatekeeper, not the PR author or reviewers - but the PR author should provide justifications that reviewers should review.
In practice, I expect that submitters won't always pay attention to whether they're supposed to tick the boxes or not. There's no access control or time limit on toggling the boxes and I've even done it by accident when using the mouse to click to focus at least once. So it's up to the gatekeeper to check that everything is fulfilled when merging. And release preparation will need to double check that the ticks are correct.