mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

x509_crt: Add LWIP implementation of inet_pton

Open rojer opened this issue 1 year ago • 2 comments

Description

LWIP is a popular TCP/IP stack implementation used on many platforms. While BIO implementation is usually provided externally, validating IP SANs does not have an interface. This seems fairly simple and non-intrusive - is this acceptable in principle?

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • [x] changelog yes
  • [ ] 3.6 backport in principle no (new feature) — but could go into 3.6.1
  • [x] 2.28 backport no (new feature)
  • [x] tests no (not an officially supported platform)

rojer avatar Mar 19 '24 02:03 rojer

Generally speaking, we accept minor portability patches for platforms that we don't support officially, with the understanding that the contributor is responsible for testing. So this is acceptable in principle, and we wouldn't add a test for it.

We don't normally backport a new feature to a long-term support branch, but this could perhaps go into 3.6.1 (it's missed 3.6.0).

gilles-peskine-arm avatar Mar 19 '24 22:03 gilles-peskine-arm

Generally speaking, we accept minor portability patches for platforms that we don't support officially, with the understanding that the contributor is responsible for testing. So this is acceptable in principle, and we wouldn't add a test for it.

ok, this makes sense and is totally fine by me.

We don't normally backport a new feature to a long-term support branch, but this could perhaps go into 3.6.1 (it's missed 3.6.0).

i see. actually, on a second thought i would appreciate a backport, since if i understand correctly 3.6 will be a LTS branch, which we intend to stay on for a while.

rojer avatar Mar 20 '24 01:03 rojer