mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

use mbedtls_ssl_session_init() to init session variable

Open BensonLiou opened this issue 1 year ago • 4 comments

Description

Use mbedtls_ssl_session_init() to init variable just like session-family APIs described

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • [x] changelog not required
  • [ ] backport required
  • [x] tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the checklist for PR contributors.

BensonLiou avatar Dec 27 '23 14:12 BensonLiou

@BensonLiou Thank you for your contribution. Could you please raise a PR with a backport? (Same commit on the top of the mbedtls-2.28 branch.)

yanesca avatar Feb 05 '24 14:02 yanesca

Hi, I didn't find a page to describe how to do backport correctly. I assume the steps should be

  1. checkout to mbedtls-2.28 and create a branch
  2. CP the commit
  3. push Please let me know if it's right or not Thanks

BensonLiou avatar Feb 16 '24 08:02 BensonLiou

checkout to mbedtls-2.28 and create a branch CP the commit push

Yes, that's right. (For completeness: if there are many commits, you might prefer (starting from mybranch) git checkout -b mybranch-2.28 && git rebase --onto origin/mbedtls-2.28 origin/development mybranch-2.28 which is equivalent to cherry-picking the commits one by one.)

gilles-peskine-arm avatar Feb 16 '24 12:02 gilles-peskine-arm

Hi @gilles-peskine-arm Thanks for the information. The backport PR is https://github.com/Mbed-TLS/mbedtls/pull/8841

BensonLiou avatar Feb 16 '24 16:02 BensonLiou