mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Published 20 hours ago • verified publisher icon Mbed-TLS

Adding PowerPC (ppc64le) support using vector instructions for AES/GCM functions.

Open dannytsen opened this issue 1 year ago • 5 comments

The supporting functions are in PowerPC assembly for ppc64le.

  1. added aes-ecb encrypt and decrypt functions.
  2. added AES key scheduling functions.
  3. added GCM multiplication functions.

Description

Please write a few sentences describing the overall goals of the pull request's commits.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • [ ] changelog provided, or not required
  • [ ] backport done, or not required
  • [ ] tests provided, or not required

Notes for the submitter

Please refer to the contributing guidelines, especially the checklist for PR contributors.

dannytsen avatar Oct 24 '23 17:10 dannytsen

This would be the first .S file in the repo, which might cause issues for some people. All other assembler is handled with asm statements in .c files. I'm adding the needs-design-approval label so that we consider this

tom-cosgrove-arm avatar Oct 25 '23 10:10 tom-cosgrove-arm

Hi @dannytsen , your latest commit is missing the sign off and hence the PR is failing the DCO checks. Please sign it off and push again, thanks.

tom-daubney-arm avatar Oct 25 '23 15:10 tom-daubney-arm

This would be the first .S file in the repo, which might cause issues for some people. All other assembler is handled with asm statements in .c files. I'm adding the needs-design-approval label so that we consider this

Hi @tom-daubney-arm , it's been a while. Any info do you need from me to get this approval? Or any suggestion? Thanks.

dannytsen avatar Jan 09 '24 14:01 dannytsen

I second Tom C's point: having assembly source files complicates build scripts, so it would be better to avoid them. I would prefer to use intrinsics if recent versions of GCC and Clang have them, do they? If not then I would prefer to use inline assembly in .c files (in GCC-like syntax).

Also, note that the CI is failing. It looks like the build is broken with armcc/armclang (some non-portable architecture detection?) and also some style checks are failing.

gilles-peskine-arm avatar Jan 09 '24 14:01 gilles-peskine-arm

Also please note that this may conflict with #8716 and probably will conflict with its follow-up PR #8813.

daverodgman avatar Feb 12 '24 15:02 daverodgman