mbedtls
mbedtls copied to clipboard
Disable MBEDTLS_SSL_RENEGOTIATION in TLS-1.3-only builds
Fixes #6200
Not applicable to 2.28.
I also get err when compile tag v3.2.1
:
[ 90%] Building C object library/CMakeFiles/mbedtls.dir/ssl_msg.c.o
/w/library/ssl_msg.c:5303:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
^
1 error generated.
Reproduce errors
- docker pull --platform=linux/amd64 visionular/wzffm-centos7:20220819T093710Z-3e40654a
- docker run --rm -it -w /w -v "/path/to/mbedtls:/w" visionular/wzffm-centos7:20220819T093710Z-3e40654a
- (container) python3 /w/scripts/config.py set MBEDTLS_SSL_PROTO_TLS1_3
- (container) python3 /w/scripts/config.py set MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_PROTO_TLS1_2
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_RENEGOTIATION
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_ENCRYPT_THEN_MAC
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_EXTENDED_MASTER_SECRET
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_PROTO_DTLS
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_DTLS_SRTP
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_DTLS_ANTI_REPLAY
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_DTLS_HELLO_VERIFY
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_DTLS_CLIENT_PORT_REUSE
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_DTLS_CONNECTION_ID
- (container) export CC="clang"
- (container) export CXX="clang++"
- (container) cmake -S "/w" -B "/w/build" \
-D CMAKE_INSTALL_PREFIX="/w/install" \
-D CMAKE_BUILD_TYPE=Release \
-D BUILD_SHARED_LIBS:BOOL=0 \
-D MBEDTLS_AS_SUBPROJECT:BOOL=1 \
-D ENABLE_PROGRAMS:BOOL=0 \
-D ENABLE_TESTING:BOOL=0 - (container) cmake --build "/w/build" -j
I get err when compile tag v3.2.1
:
[ 94%] Building C object library/CMakeFiles/mbedtls.dir/ssl_tls12_server.c.o
/w/library/ssl_msg.c:5303:9: error: unused variable 'ret' [-Werror,-Wunused-variable]
int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
^
1 error generated.
make[2]: *** [library/CMakeFiles/mbedtls.dir/build.make:160: library/CMakeFiles/mbedtls.dir/ssl_msg.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/w/library/ssl_tls.c:2856:13: error: code will never be executed [-Werror,-Wunreachable-code]
*olen = used;
^~~~
1 error generated.
make[2]: *** [library/CMakeFiles/mbedtls.dir/build.make:188: library/CMakeFiles/mbedtls.dir/ssl_tls.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:219: library/CMakeFiles/mbedtls.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Reproduce errors
- ...
- ...
- (container) python3 /w/scripts/config.py set MBEDTLS_HAVE_SSE2
- (container) python3 /w/scripts/config.py unset MBEDTLS_DEBUG_C
- (container) python3 /w/scripts/config.py unset MBEDTLS_SSL_SRV_C
- ...
- ...
- ...
- ...(use tls 1.3 only)
- ...
- ...
- cmake ...
@gilles-peskine-arm This PR has conflicts