mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

cert_write - add a way to set extended key usages - rebase

Open daverodgman opened this issue 3 years ago • 5 comments

Rebased/updated version of #277.

Requires backports: no.

Confirm nwilson has signed the CLA, so no need for sign-off by him.

daverodgman avatar Jul 22 '22 14:07 daverodgman

Why is there still a pending CI build when the last change was 7 days ago?

tom-cosgrove-arm avatar Aug 22 '22 11:08 tom-cosgrove-arm

There's a merge conflict again :(

gilles-peskine-arm avatar Aug 22 '22 15:08 gilles-peskine-arm

@tom-cosgrove-arm GitHub shows the CI status as pending if it has received a notification that the CI job started, but not a notification that the CI job passed/failed. This can happen if there was a network glitch when the CI server tried to report back.

There's also a limit on the number of times a CI can report the status of a given commit, so PRs that have had a lot of pr-merge runs sometimes stop updating. I can't find the limit but it's high enough that we rarely if ever encounter it on “normal” PRs, so I don't think that's happened here. We encounter that on very old PRs that have had no update in a while but have had re-trigger events, especially the PRs we put up to test CI script updates.

gilles-peskine-arm avatar Aug 22 '22 15:08 gilles-peskine-arm

I rebased onto origin/development and saw no conflicts, so not sure why GitHub reported conflicts. Anyway, I've updated this PR.

daverodgman avatar Aug 24 '22 14:08 daverodgman

Still reporting a conflict in tests/suites/test_suite_x509write.data, which hasn't been updated since 9 Aug 2022!

tom-cosgrove-arm avatar Aug 25 '22 06:08 tom-cosgrove-arm

The last commit (DER format support) isn't strictly related, but I found this useful when looking at an unrelated issue, so I've bundled it in here. It improves consistency with e.g. programs/pkey/gen_key.

daverodgman avatar Oct 27 '22 16:10 daverodgman