mbedtls
mbedtls copied to clipboard
Reduce RAM - move some variables to .rodata
You miss the sign-off-by line in the commit message.
How do I edit the commit message?
You miss the sign-off-by line in the commit message.
How do I edit the commit message?
Edit it locally : "git commit --amend".
Then force push the branch to your Mbed TLS fork, something like: "git push
For a single commit:
git commit --no-edit --amend --signoff
For all commits since the last merge:
git rebase -i --signoff
and keep all the commits on “pick”.
I've made this PR with github web interface. I cannot use git command line
I've made this PR with github web interface. I cannot use git command line
In that case the simpler is maybe to just close this PR and create a new one.
I think since the author has added a sign-off to the top of this PR description and seems happy, I'll add a sign-off so we can proceed.
I have rebased on top of development - of the 3 arrays, 2 were deprecated and have since been removed, so only 1 remains.
DCO is failing due to having a signature that doesn't match the PR author.
So this changes
text data bss dec hex filename
37565 789 0 38354 95d2 library/ssl_tls-aarch64-development.o
37573 777 0 38350 95ce library/ssl_tls-aarch64-5894.o
Since both text and data will be in flash, this seems like a (very minor) win - but suggests other patterns to look for.
@Xeenych can you add a Signed-off-by: line to the commit so that it passes the DCO commit check?
It's just better with const
anyway