MazeXP
MazeXP
~~Can the status field added to the `Modify Channel` API call added as well~~
You have the commit about adding the new permissions in this PR as well by accident.
Seems like we will get a new endpoint for setting the voice channel status: https://github.com/discord/discord-api-docs/pull/6400 According to https://github.com/discord/discord-api-docs/pull/6398#issuecomment-1709042370 it will not be set through the typical `Modify Channel` call.
A basic example when the cache will return wrong information for a different token is simply every URL that includes `/@me/` in the URL. (https://github.com/Remora/Remora.Discord/blob/main/Backend/Remora.Discord.API.Abstractions/API/Rest/IDiscordRestUserAPI.cs#L53) In addition it could be...
A good writeup. For the `PeriodicTimer` it would be important to provide a fallback for TFM netstandard2.1
> > A good writeup. > > For the `PeriodicTimer` it would be important to provide a fallback for TFM netstandard2.1 > > Thanks! I was under the impression that...
Looks good so far. You might add the new field also in the JSONs used by tests: - https://github.com/Remora/Remora.Discord/tree/main/Tests/Remora.Discord.Tests/Samples/Objects/USER - https://github.com/Remora/Remora.Discord/tree/main/Tests/Remora.Discord.Tests/Samples/Objects/USER_MENTION
Thanks for the PR. Velvet mentioned it already that you are missing the JSON property name configuration for the `temporary` field and the registration of the type itself in `Remora.Discord.API`....
The endpoint does not need more testing. It is a test about the actual JSON object.
LGTM! Thanks again. Now let's wait on review of @Nihlus and his final word about the `InviteMetadata` vs `InviteWithMetadata`.