zoom_pinch_overlay icon indicating copy to clipboard operation
zoom_pinch_overlay copied to clipboard

Unable to zoom properly with other scrollable widgets

Open umuieme opened this issue 1 year ago • 5 comments

Describe the bug When the ZoomOverlay widget is used in a listview or pageview or any other scrollable widget then it's hard for the user to trigger the zoom. I have cloned and run the example app of this repo and it is the same issue. Only pinching in a particular way can trigger the zooming.

To Reproduce Steps to reproduce the behavior:

  1. Run the example app without any changes
  2. Try to zoom in on the image in the same direction as the scroll widget.

Expected behavior Users should be able to trigger zoom by pinching with two fingers in any way or any direction.

Screenshots

https://user-images.githubusercontent.com/13749337/226119483-5e3680c9-3de3-4be3-aa2e-ac71dfddd35d.mp4

Smartphone (please complete the following information):

  • Device: Samsung s22 ultra
  • OS: One UI 5.1 based on android 15

umuieme avatar Mar 18 '23 16:03 umuieme

I have created a workaround for this by letting the user control based on the number of touches on the screen. I simply created a callback that sends the number of touches currently on the image. This method has minimum change in the library itself with no changes in implementation and in the same time let the developer control it. This can be achieved without any changes in library but it would be make the life easier.

I can create a PR if you are open for it.

umuieme avatar Mar 18 '23 16:03 umuieme

Hi @umuieme, thanks for taking the time to open this issue. This issue has been known for quite some time and I just didn't have time to tackle it. So yes! the PR would be very much welcome 😁

Mayb3Nots avatar Mar 19 '23 00:03 Mayb3Nots

I have created a PR for this.

https://github.com/Mayb3Nots/zoom_pinch_overlay/pull/13

umuieme avatar Mar 20 '23 03:03 umuieme

No more updates on that issue?

guikfe avatar May 20 '23 14:05 guikfe

@guikfe you can use my fork for the time being if it solves the problem

umuieme avatar May 20 '23 17:05 umuieme