Stackoverflow-Clone-Frontend icon indicating copy to clipboard operation
Stackoverflow-Clone-Frontend copied to clipboard

[Frontend]: Add Spinners To All Actionable Buttons

Open Mayank0255 opened this issue 2 years ago • 22 comments

Add spinners to all buttons so that when the user clicks a button, it shows a spinner and the user gets to know that some process is going on

Mayank0255 avatar Jul 01 '22 19:07 Mayank0255

Hey Mayank Could you assign this to me? I'd like to assist on this?

Also can i use this without setting up the backend locally?

shravankumar-fs avatar Jul 03 '22 16:07 shravankumar-fs

@shravankumar-fs Actually backend would be required, otherwise from where will you be getting all the data and test properly.

Let me know if you are in to take up this issue, will assign it to you then

Mayank0255 avatar Jul 03 '22 19:07 Mayank0255

And this might help for loading buttons, https://stackoverflow.design/product/components/buttons/#loading

Mayank0255 avatar Jul 03 '22 19:07 Mayank0255

@shravankumar-fs

Found a workaround to avoid setting up backend, Can just change the url here to this https://stackoverflow-clone-backend.herokuapp.com

Let me know if you are interested and would want me to assign it to you

Mayank0255 avatar Jul 09 '22 07:07 Mayank0255

Hi @Mayank0255 Please assign it to me, I'll do.

Also currently which buttons need this feature?

I see some places with no action event being triggered

shravankumar-fs avatar Aug 26 '22 13:08 shravankumar-fs

@shravankumar-fs Ya sure, go ahead.

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

Mayank0255 avatar Aug 27 '22 07:08 Mayank0255

@shravankumar-fs Any progress on this?

Mayank0255 avatar Sep 03 '22 03:09 Mayank0255

Hi.. is anyone working on this issue.. I would like to work on it if no one else is assigned.

amreekminocha avatar Sep 26 '22 07:09 amreekminocha

@amreekminocha Ya sure, go ahead.

Any idea how much time will it take you to complete this task?

Mayank0255 avatar Sep 26 '22 16:09 Mayank0255

Thanks for assigning.. I'll go through the project once then i'll tell you the required time

amreekminocha avatar Sep 27 '22 14:09 amreekminocha

Thanks for assigning.. I'll go through the project once then i'll tell you the required time

Sure, not an issue

mayank-zoman avatar Sep 27 '22 14:09 mayank-zoman

Hi I am having this error Stackoverflow-Clone-Frontend/node_modules/webpack-dev-server/lib/Server.js:348 } catch {

Can you help

amreekminocha avatar Sep 28 '22 13:09 amreekminocha

@amreekminocha

Can you pls send me the complete error? I can't firgure out anything from this.

And can you please let me know that did you get this error while setting up the repo or what?

Mayank0255 avatar Sep 28 '22 17:09 Mayank0255

Yes.. I am getting this error while setting the frontend repo Screenshot 2022-09-29 at 2 45 32 PM

amreekminocha avatar Sep 29 '22 09:09 amreekminocha

Hi do share a point of contact as well

amreekminocha avatar Sep 29 '22 13:09 amreekminocha

Hi do share a point of contact as well

sure, you can reach out to me on discord https://discords.com/bio/p/mayank0255

Mayank0255 avatar Oct 01 '22 11:10 Mayank0255

Yes.. I am getting this error while setting the frontend repo Screenshot 2022-09-29 at 2 45 32 PM

Can you try installing react-scripts individually and then starting the server?

npm i react-scripts

Mayank0255 avatar Oct 01 '22 11:10 Mayank0255

@amreekminocha and check on which node version are in currently? It should be above 14, 16 is recommended

Mayank0255 avatar Oct 01 '22 11:10 Mayank0255

This worked.. thanks

amreekminocha avatar Oct 02 '22 15:10 amreekminocha

Hi Can you share the buttons where the spinner is require

amreekminocha avatar Oct 09 '22 07:10 amreekminocha

Hi Can you share the buttons where the spinner is require

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

It's ok if you miss some places

Mayank0255 avatar Oct 09 '22 09:10 Mayank0255

@amreekminocha how's the progress on this?

Mayank0255 avatar Oct 16 '22 11:10 Mayank0255