Maksym Vlasov

Results 45 comments of Maksym Vlasov

Can confirm the same issue on: * Windows 10H22 * Windows 10H22 WSL2 (Ubuntu 20.04) * Ubuntu 22.04.3 Gitlens v14.6.1 VS Code 1.85.1 git version 2.34.1 Fixed by removing `[blame]`...

Looks like https://github.com/antonbabenko/pre-commit-terraform/issues/622#issuecomment-1945725749 could be related to this issue ```dockerfile WORKDIR $PRE_COMMIT_CACHE COPY .pre-commit-config.yaml . RUN \ git init . && \ pre-commit install --install-hooks \ && chmod -R a+rwX...

Also, it can be done in slightly different way: https://github.com/StyraInc/regal/blob/4d7cbe19ff5dacc51e957f8811d30e681ddc7ea9/.pre-commit-hooks.yaml#L15-L20 Could be implemented after: https://github.com/antonbabenko/pre-commit-terraform/pull/644

@adarobin Adapt. I think that we can make something like ```yaml --hook-config=binary= ``` Which will add much more flexibility than just adding support for tofu

>While I support the approach, just out of curiosity (and for fun): how many more TF derivatives do you expect to appear in future? Good one :D I more thinking...

Yeah, we definitely can change hooks names in [2.0.0 \[BREAKING CHANGES\]](https://github.com/antonbabenko/pre-commit-terraform/milestone/3) milestone (whenever it will come) to reduce wrong perceptions. If you have any suggestions - please open a separate...

Locks (as files or dirs) do not work. 1. Just remember the state of `.terraform/` dir - which files exist and which do not 2. Init everything async 3. If...

> If we wanted to do this for the whole tree, I would say some 2h just to refresh cache and/or update providers lock - it seems to take same...

Okay, let's assume that `terraform_validate` failed during `t init`, wrote corrupted SHAs and then `terraform_providers_lock` passed 1. You still not able to commit that, as one of hooks failed (`terraform_validate`)...

If you think that such docs are confusing or not enough and you have ideas in which places there should be some extra mentions of that - please let us...